-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validating SAML XML schemas #754
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
We can also move the patch outside, and wrap each 3rdparty interaction instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not patch third party, packaging might override it
@nickvergessen @juliushaertl did the adjustments, and it is working on my test setup. If I get green lights from you, I'd clean up the commits before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works here as well and code looks good 👍
Signed-off-by: Arthur Schiwon <[email protected]>
006f05f
to
c835266
Compare
FWIW, I was experiencing same issues and driving me insane. Narrowed it down to XML validation today morning and woke up with your fix - appreciated! Applying this patch fixes it in my affected setup with ADFS too. |
/backport to stable-5.1 |
The backport to stable-5.1 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-5.1
git pull origin stable-5.1
# Create the new backport branch
git checkout -b fix/foo-stable-5.1
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-5.1 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable-3.3 |
The backport to stable-3.3 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-3.3
git pull origin stable-3.3
# Create the new backport branch
git checkout -b fix/foo-stable-3.3
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.3 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Fixes #14. Problem exists since Nextcloud 27.0.1 (see nextcloud/server@2274977). Also see nextcloud/user_saml#754.
No description provided.